On Sun, Sep 27, 2020 at 01:23:25PM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > The current documentation is vague about what happens with > > --group=trailer:signed-off-by when we see a commit with: > > > > Signed-off-by: One > > Signed-off-by: Two > > Signed-off-by: One > > > > We clearly should credit both "One" and "Two", but should "One" get > > credited twice? The current code does so, but mostly because that was > > the easiest thing to do. > > I thought that "the current documentation" as of step 4/8 were quite > clear about double counting ;-). It was clear to me that the commit would be counted at least twice: once for the "one" bucket and once for the "two" bucket, but not that it would count twice for the "two" bucket. Or at least, I didn't think of this issue at all back when I wrote the original patch long ago, and only noticed the problem when I revisited it. :) Anyway, I think the semantics at the end of the series are quite sensible. -Peff
