On Sat, Sep 26, 2020 at 02:39:32PM +0200, Martin Ågren wrote:
> > +/*
> > + * Initialize "iter" in preparation for walking over the trailers in the commit
> > + * message "msg". The "msg" pointer must remain valid until the iterator is
> > + * released.
> > + *
> > + * After initializing, we are not yet pointing
> > + */
>
> Truncated sentence. "... not yet pointing at any trailer"?
Oops. Yes, though I expanded it to:
* After initializing, note that key/val will not yet point to any trailer.
* Call advance() to parse the first one (if any).
Obviously another convention would be:
for (trailer_iterator_init(&iter, msg);
!trailer_iterator_done();
trailer_iterator_advance()) {
}
but I don't think it matters much either way as long as it's clearly
documented.
-Peff
