Hi Peff,
Some random thoughts follow on this patch and a few others.
On Fri, 25 Sep 2020 at 09:04, Jeff King <peff@xxxxxxxx> wrote:
>
> In preparation for adding more grouping types, let's
> refactor the committer/author grouping code. In particular:
>
> - the master option is now "--group", to make it clear
> that the various group types are mutually exclusive. The
> "--committer" option is an alias for "--group=committer".
I think this is more than a refactoring of the code. The user interface
is also refactored (if that's even the right word). From the subject and
the first sentence above, I did not expect this first "-" item, nor that
the patch would touch Documentation/.
> + enum {
> + SHORTLOG_GROUP_AUTHOR = 0,
> + SHORTLOG_GROUP_COMMITTER
> + } group;
You could reduce the patch noise by adding a trailing comma, see
cc0c42975a ("CodingGuidelines: spell out post-C89 rules", 2019-07-16).
(I do realize that you later redefine all values anyway.)
Martin
