Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: > It is very uncommon style to hide the subshell as these two tests do: > > test_expect_success 'title' '( > ... > )' > > Instead, these should be formatted as: > > test_expect_success 'title' ' > ( > ... > ) > ' > > Note that the "(" and ")" of the subshell are indented with a TAB, and > then the body of the subshell is indented again with another TAB in > order to comply with current style guidelines. > > Fixing these might possibly be done in patch [1/11], however, they are > so unusual and would change indentation of the body lines that they > might deserve a patch of their own to avoid being lost in the noise of > [1/11]. I agree that adding that to 01/11 might be too noisy, but 04/11 may be a good match. Thanks.