On Fri, Sep 25, 2020 at 1:03 PM shubham verma <shubhunic@xxxxxxxxx> wrote:
> t7001: change the style for cd according to subshell
>
> In some tests there is not a proper spaces after opening paranthesis
> and before cd. So, Lets change the style for cd according to subshell.
Nits:
s/space/newline/
s/paranthesis/parenthesis/
s/So, Lets change/Change/
However, a more significant observation is that this change is
actually specific to the formatting of subshells, and has nothing to
do with placement of `cd`, so calling out `cd` in the commit message
is misleading. I'd probably drop mention of `cd` altogether and write
the commit message something like this:
t7001: modernize subshell formatting
Some test use an old style for formatting subshells:
(command &&
...
Update them to the modern style:
(
command &&
...
The actual patch is fine.
> Signed-off-by: shubham verma <shubhunic@xxxxxxxxx>
