Miriam Rubio <mirucam@xxxxxxxxx> writes: > These patches correspond to a second part of patch series > of Outreachy project "Finish converting `git bisect` from shell to C" > started by Pranit Bauva and Tanushree Tumane > (https://public-inbox.org/git/pull.117.git.gitgitgadget@xxxxxxxxx) and > continued by me. > > This patch series version is composed by the first six patches of the > previous version due to a bug discovered during the test stage, that > affects the rest of the patches and that needs to be fixed before > sending them. Thanks for being careful. > * Rebased on 385c171a01, (Fifteenth batch, 2020-09-18) to update command > help messages. Personally I find this rebase unwarranted. What ef4d9f8a (bisect: swap command-line options in documentation, 2020-08-28) on the 'master' did does not overlap with this series in any meaningful way. Since it is also trivial to adjust these patches back on e9b77c84 (Tenth batch, 2020-08-24) on which the previous round was based, I won't complain ;-) > [4/6] bisect--helper: reimplement `bisect_autostart` shell function in C > > * Amend commit message. > * Change to `return -1` when we cannot autostart. > * Add `|| exit` to bisect-autostart call in shell script. Sounds good. > [6/6] bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell > functions in C > > * Amend commit message. > * Amend new modes order in cmdmode enum. Meaning that the two new ones can just be at the end and there wasn't a reason for them to come before autostart? OK. > * Add `|| exit` to bisect-auto-next call in shell script. OK. Thanks.
