On Tue, Sep 22, 2020 at 10:55 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Jeff King <peff@xxxxxxxx> writes: > > > - this will run only on PRs. That's helpful for people using > > GitGitGadget, but it might also be useful for people just running the > > CI by pushing branches, or looking at CI builds of Junio's next or > > seen branches. Could we make it work there? Obviously we wouldn't be > > able to rely on having PR data, but I wonder if "git log > > HEAD..$branch" would be sufficient. > > Yes, I like that very much. If a push triggers a CI run to notice > whitespace breakage and other mechanically detectable errors, that > would prevent embarrassment before even a pull request is opened. This was originally started as a push action which was expected to be in the GitGitGadget workflow. It was changed to run on PRs using the more helpful PR data. The original GitGitGadget issue suggested a build target to run the check, which could have been part of the CI build (or a local build). Doing the check later as part of the PR process is consistent with GitGitGadget performing linting on the PR request, with similar opportunities for embarrassment. ...chris.
