Re: [PATCH v2] style(git-gui): Fix mixed tabs & spaces; Prefer tabs.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/09/20 04:01PM, Serg Tereshchenko wrote:
> Hi Pratyush,
> 
> Thanks for suggestion about scissors, i was wondering how to do this
> properly, i'll try it next time.
> 
> > I'm not on board with this entire hunk. In many C projects (like Linux, 
> > Git, etc) the "switch" and the "case" are on the same indent level. I 
> > can see instances of this in almost every switch-case block in 
> > git-gui.sh as well. We should stick to the local convention here and 
> > drop this hunk.
> > 
> > I can make these changes locally and merge them so no need to re-roll... 
> > unless you have any counter points that is.
> 
> I have no objections, please drop that hunk.

Merged with the above changes. Thanks.
 
> --
> Regards,
> Serg Tereshchenko

-- 
Regards,
Pratyush Yadav



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux