On Fri, Sep 18, 2020 at 06:27:40PM +0200, SZEDER Gábor wrote: > On Thu, Sep 17, 2020 at 10:59:27PM -0400, Taylor Blau wrote: > > When 'get_or_compute_bloom_filter()' needs to compute a Bloom filter > > from scratch, it looks to the default 'struct bloom_filter_settings' in > > order to determine the maximum number of changed paths, number of bits > > per entry, and so on. > > > > All of these values have so far been constant, and so there was no need > > to pass in a pointer from the caller (eg., the one that is stored in the > > 'struct write_commit_graph_context'). > > > > Start passing in a 'struct bloom_filter_settings *' instead of using the > > default values to respect graph-specific settings (eg., in the case of > > setting 'GIT_TEST_BLOOM_SETTINGS_MAX_CHANGED_PATHS'). > > I think this description misses the most important aspect of this > patch: it fixes, even if only partially, the half-broken fix in > 0087a87ba8 (commit-graph: persist existence of changed-paths, > 2020-07-01). Could you suggest an amendment? I understand what you are saying below, but I'm not sure how or if you want it incorporated into this patch. If you feel this is critical to change (I have no opinion either way), then I'm happy to send a re-roll once review has stabilized. When do you plan on finishing your read-through of this v3? Thanks, Taylor
