Hi Junio, On Thu, 17 Sep 2020, Junio C Hamano wrote: > "Johannes Schindelin via GitGitGadget" <gitgitgadget@xxxxxxxxx> > writes: > > > From: Johannes Schindelin <johannes.schindelin@xxxxxx> > > > > When using CMake to generate the files required to build Git in Visual > > Studio, a bunch of files are generated. We will want to prevent them > > from being tracked in Git. > > > > Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx> > > --- > > Ignore files generated by CMake > > > > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-735%2Fdscho%2Fignore-generated-cmake-files-v1 > > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-735/dscho/ignore-generated-cmake-files-v1 > > Pull-Request: https://github.com/gitgitgadget/git/pull/735 > > > > .gitignore | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/.gitignore b/.gitignore > > index 9673e792db..36f5ac4138 100644 > > --- a/.gitignore > > +++ b/.gitignore > > @@ -239,3 +239,9 @@ Release/ > > /git.VC.VC.opendb > > /git.VC.db > > *.dSYM > > +*.vcxproj > > +*.vcxproj.filters > > +/CMakeCache.txt > > +/CMakeFiles/ > > +/*.cmake > > +/DartConfiguration.tcl > > Good to catch these cruft. > > Does the equivalent of "make distclean" need to be updated to clean > them as well, or is it sufficient to ignore the build procedure and > just rely on "git clean -f -x"? Since CMake in conjunction with Visual Studio completely side-steps `make`, I think it would make most sense to ignore `make distclean` in this context and go for `git clean -dfx` instead. Ciao, Dscho
