On Fri, Sep 18, 2020 at 1:03 AM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > > + if (!check_reachable) > > return; > > I would probably drop this conditional return altogether since it > incorrectly conveys to the reader that it is legal to call this > function with NULL for 'check_reachable', whereas, in reality, it > would be pointless to do so. [...] Nevermind. I'm an idiot. I forgot that filter->reachable_from and filter->unreachable_from may indeed validly be NULL.
