Re: [PATCH 09/15] remote-mediawiki tests: use "$dir/" instead of "$dir."

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 16, 2020 at 12:29:12PM +0200, Ævar Arnfjörð Bjarmason wrote:

> Change UI messages to use "$dir/" instead of "$dir.". I think this is
> less confusing.

Yeah, a trailing slash is a nice indicator. In the first message,
though:

> -		echo "$MW_FILENAME downloaded in $(pwd). "\
> +		echo "$MW_FILENAME downloaded in $(pwd)/ "\
>  			"You can delete it later if you want."

...we've lost the period separating the two sentences. So you get:

  foo downloaded in /some/path/  You can delete it later if you want.

(the two spaces are because "echo" adds an extra space between the
arguments). Maybe:

  foo downloaded in /some/path/; you can delete it later if you want.

or something?

-Peff



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux