On 9/14/2020 4:36 PM, Taylor Blau wrote: > On Mon, Sep 14, 2020 at 04:31:03PM -0400, Derrick Stolee wrote: >> On 9/14/2020 4:12 PM, Taylor Blau wrote: >>> - This patch (attached below the scisors) instead of 12/12, and >>> >>> - This [1] patch instead of 10/12. >>> >>> [1]: https://lore.kernel.org/git/20200910154516.GA32117@nand.local/ >>> >>> Let me know if you'd rather have a full re-roll. >> >> It's getting a bit difficult to track all of these "use this instead" >> patches. But, I'm not the one applying them, so maybe that's not actually >> a problem. > > The above list is the only changes that I've made, so I'm happy if Junio > wants to follow what's written there, but I'm equally happy to send a > new reroll. > >> You might need a re-roll, anyway, as I have a few comments here: > > Let's take a look... > >> You also introduce commitGraph.maxNewFitlers here, which is not >> mentioned in the commit message anywhere. In fact, it might be >> good to include it as a separate patch so its implementation and >> tests can be isolated from the command-line functionality. > > I could go either way on both of these, to be honest. I don't think > there's anything interesting that isn't said in the documentation > changes introduced by that commit that is worth convering there, so I'm > not sue 'commitGraph.maxNewFilters' needs the additional call-out. This is fine. Adding an option along with the config version of it is easy enough. Just a thought for future series. I'm fine with the series as-is. My nits are just that. Thanks, -Stolee
