Derrick Stolee <stolee@xxxxxxxxx> writes:
> On 9/14/2020 3:49 PM, Rafael Silva wrote:
>> Hi Everyone,
>>
>> I found a minor bug when testing the new maintenance built-in command that was
>> introduced on 679768e2a1 (maintenance: create basic maintenance runner, 2020-08-25) submitted in [1]
>
> Thank you for identifying the original patch! My gut reaction was that
> this is just in the Part III code which adds subcommands, but that is
> incorrect.
>
>> (gdb) list
>> 1628 int cmd_maintenance(int argc, const char **argv, const char *prefix)
>> 1629 {
>> 1630 if (argc == 2 && !strcmp(argv[1], "-h"))
>> 1631 usage(builtin_maintenance_usage);
>> 1632
>> 1633 fprintf(stdout, "run");
>> 1634 if (!strcmp(argv[1], "run"))
>> 1635 return maintenance_run(argc - 1, argv + 1, prefix);
>> 1636 if (!strcmp(argv[1], "start"))
>> 1637 return maintenance_start();
>> (gdb) print argc
>> $5 = 1
>> (gdb) print argv[1]
>> $6 = 0x0
>>
>> Hope all this information helps with the fixing it
>
> Thank you so much for the report!
>
> The patch below applies to ds/maintenance-part-1, to fix the problem.
> Hopefully it also merges cleanly with the changes in ds/maintenance-part-3,
> but I can deal with that when I submit my next re-roll.
Yuck. I am pretty sure that I did spot this myself during the
review cycle, but apparently it slipped through X-<.
Will apply. Thanks.
