On Fri, Sep 11, 2020 at 02:59:34PM -0400, Taylor Blau wrote: > I think that we have to treat "-1" as the no-limit indicator, or > otherwise we'd have to specify some other way to say we don't want to > generate any filters. With this patch, users can write: > > $ git commit-graph write --changed-paths .. --max-new-filters=0 > > to generate a commit-graph without writing any new filters. This is > important to be able to do since we also have a > 'commitGraph.maxNewFilters' configuration, which callers may want to > override. OK, that makes sense. Consistency would be nice, but I agree it just wouldn't work here (and we're not entirely consistent anyway, so it's not that big a loss). -Peff
