On Wed, Sep 9, 2020 at 12:50 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > Hmph, I am not necessarily sure about "need to duplicate" [*1*], but > I do agree with the patch text---the bit should not belong to a > single "files-backend" backend. > > [Footnote] > > *1* obviously, a better alternative, if possible, would be to let > the more generic layer do so without forcing the backends to > duplicate. But even if such a change were possible and we > decide to avoid duplication, it does not make sense to have this > bit specifically defined for the files-backend and nobody else. I'm not sure if it is possible. REFS_LOG_ONLY is used in the split_head_update() which is called from the middle of the files_transaction_prepare(). In particular, it can happen after a number of locks have already been taken. If this moves into the generic layer, the head split happens before the locks are taken, which could alter behavior. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
