On 9/7/2020 1:16 PM, Edmundo Carmona Antoranz wrote:
> ---
Please include sign-off. I saw you reported your intention there
in another message, but it's probably best to just send it again.
This message could also mention 14438c4 (introduce hasheq() and
oideq(), 2018-08-28) which introduced oideq().
This use of !oidcmp() was introduced by 0906ac2b (blame: use
changed-path Bloom filters, 2020-04-16). My bad. There is no
good reason to introduce this use since it is well after the
oideq() method was introduced.
> @@ -1353,8 +1353,8 @@ static struct blame_origin *find_origin(struct repository *r,
> else {
> int compute_diff = 1;
> if (origin->commit->parents &&
> - !oidcmp(&parent->object.oid,
> - &origin->commit->parents->item->object.oid))
> + oideq(&parent->object.oid,
> + &origin->commit->parents->item->object.oid))
> compute_diff = maybe_changed_path(r, origin, bd);
The code itself looks correct.
Thanks,
-Stolee
