This series addresses a few comments[2,3,4,5] which cropped up during review of the series which added --interdiff and --range-diff options to git-format-patch[1]. That series made it into 'next' before I could address the comments, so these patches (based upon 'master') make minor tweaks "incrementally" (over 2 years late). [1]: https://lore.kernel.org/git/20180722095717.17912-1-sunshine@xxxxxxxxxxxxxx/ [2]: https://lore.kernel.org/git/CACsJy8C8RK6HkfoEYJGZg=sgtJS0WksHD3=7Souw3jYebRo=Sg@xxxxxxxxxxxxxx/ [3]: https://lore.kernel.org/git/xmqqh8kp4otz.fsf@xxxxxxxxxxxxxxxxxxxxxxxxx/ [4]: https://lore.kernel.org/git/CAPig+cSuYUYSPTuKx08wcmQM-G12_-W2T4BS07fA=6grM1b8Gw@xxxxxxxxxxxxxx/ [5]: https://lore.kernel.org/git/xmqqva93t4u7.fsf@xxxxxxxxxxxxxxxxxxxxxxxxx/ Eric Sunshine (3): diff: move show_interdiff() from its own file to diff-lib diff-lib: tighten show_interdiff()'s interface format-patch: use 'origin' as start of current-series-range when known Makefile | 1 - builtin/log.c | 22 +++++++++++++--------- diff-lib.c | 25 +++++++++++++++++++++++++ diff.h | 7 +++++++ interdiff.c | 28 ---------------------------- interdiff.h | 8 -------- log-tree.c | 4 ++-- 7 files changed, 47 insertions(+), 48 deletions(-) delete mode 100644 interdiff.c delete mode 100644 interdiff.h -- 2.28.0.618.gf4bc123cb7