On 2020-08-11 00:55:09-0400, Jeff King wrote: > On Tue, Aug 11, 2020 at 04:17:28AM +0000, Emma Brooks wrote: > > > On 2020-08-10 06:02:49-0400, Jeff King wrote: > > > There was a little discussion in response to v1 on whether we could > > > reuse the existing C mailmap code: > > > > > > https://lore.kernel.org/git/20200731010129.GD240563@xxxxxxxxxxxxxxxxxxxxxxx/ > > > > > > Did you have any thoughts on that? > > > > I think it's probably not worth the effort to make the necessary changes > > to "rev-list --header" Junio mentioned, just for gitweb. > > Yeah, I agree that probably doesn't make sense to change "rev-list > --header". I wonder if git could be using "rev-list --format" instead, > though, and asking for the specific things it wants. That could improve > more than just this case, too (e.g., the C code would be parsing and > normalizing author/committer idents, which could make handling of badly > formatted ones more consistent with other Git tools). > > It may be a big change, though. I don't know the gitweb code very well. This idea works in my testing, and it should be a small change. However, I couldn't find a way to get "rev-list --format" to separate commits with NULs. Is there a way to do this that I'm missing? I was able to try the concept in gitweb by switching the "rev-list --format" call I would've used to a similar log call, and it seems like a fairly small change.
