On 9/3/2020 5:58 PM, Junio C Hamano wrote: > Derrick Stolee <stolee@xxxxxxxxx> writes: > >> On 6/23/2020 4:56 PM, Michael Forney wrote: >>> This is needed when repo_init_revisions() is called with a repository >>> that is not the_repository to ensure appropriate repository is used >>> in repo_parse_commit_internal(). If the wrong repository is used, >>> a fatal error is the commit-graph machinery occurs: >>> >>> fatal: invalid commit position. commit-graph is likely corrupt >>> >>> Since revision.c was the only user of the parse_commit_gently >>> compatibility define, remove it from commit.h. >> >> Is this demonstrable in a test case, to prevent regressions? > > It appears that Michael tried and failed. Even if we do not > currently have a caller that asks these functions in revision.c to > work on a repository that is not the primary one (i.e. in a > submodule), in which case these patches may not be fixing any bug > that can be triggered in the current code, it is quite obvious that > these functions misbehave once a caller starts asking them to work > on a repository other than the primary one. > > So, given that ... > >> >> I counted 9 copies of parse_commit[_gently]() in my version >> of revision.c, so it looks like you caught them all. > > ... we should be able to proceed with the code as-is, I guess Yes, I think this is an improvement regardless. Thanks, for the reminder. -Stolee
