Re: [PATCH] RFC: refs: add GIT_DEBUG_REFS debugging mechanism

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 02, 2020 at 10:44:22PM -0700, Jonathan Nieder wrote:

> Summary:
> 
> - if this is only going to be used for tests and for ad hoc debugging,
>   I'd suggest sticking to the simple trace_key based unstructured
>   tracing API

Yeah, from my look at the debug patch, this seems sensible.

As clever as the "debug" ref-backend wrapper object is, I also wonder if
it might be simpler to just add trace calls to all of the outer
functions (e.g., ref_transaction_prepare(), etc). Unlike a "real" OO
system, we're not typically passing around the polymorphic ref_store
type, but always access it through those type-agnostic wrappers. But
maybe that would end up just as long. I dunno.

-Peff



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux