Hi Junio, On Wed, 26 Aug 2020, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > Actually, `SKIP_DASHED_BUILT_INS` does not _only_ have an impact on `make > > install`: > > ... > > See how `git-add.exe` is linked in the first, but not in the second run? > > OK, that is one more reason why we do want to have 3/3 applied not > for all tasks in the CI , but for subset of tasks that includes the > Windows task. If we had multiple Windows tasks, it may even be > better to have only to some tasks, and allow other tasks build > git-add.exe, so that both can be tested for the primary intended > platform. If you want to skip this patch, that's fine with me. But I would like to clarify what I perceive as a misunderstanding: this patch is not about testing whether it would install the necessary files or not. What this patch does is simply to complete the mission of e4597aae6590 (run test suite without dashed git-commands in PATH, 2009-12-02): to make sure that our very own scripts do not use dashed invocations of built-in commands. In that respect, I find it to make more sense to either do it, or not do it (even if I don't quite understand why we wouldn't do it), instead of doing it only for one platform. Ciao, Dscho
