Miriam Rubio <mirucam@xxxxxxxxx> writes: > These patches correspond to a second part of patch series > of Outreachy project "Finish converting `git bisect` from shell to C" > started by Pranit Bauva and Tanushree Tumane > (https://public-inbox.org/git/pull.117.git.gitgitgadget@xxxxxxxxx) and > continued by me. > > These patch series emails were generated from: > https://gitlab.com/mirucam/git/commits/git-bisect-work-part2-v6ps. > > I would like to thank the reviewers for their help. > > General changes > --------------- > > * Rebase on master branch: e9b77c84a0 (Tenth batch, 2020-08-24) Was this done because the updated series newly depends on something that was not available in f402ea68 (The fifth batch, 2020-06-25)[*] but is available in e9b77c84a0 (Tenth batch, 2020-08-24), and/or is there a change between the fifth and tenth batch that conflicts with the old iteration? Side note: the previous iteration, which is queued in 'seen', was applied on top of f402ea68. Updating to a new base is not by itself wrong, but please also describe the reason why the topic was rebased, perhaps like * Rebased on e9b77c84a0 (Tenth batch, 2020-08-24), to build on the strvec API (instead of argv_array) and adjust to the codebase after the "--first-parent" feature was added. or something like that. > [6/13] bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell > functions in C > > * Change `file_exists(git_path_bisect_head())` to a refs API call. Very much appreciated. Thanks.
