Junio C Hamano <gitster@xxxxxxxxx> writes:
> David Kastrup <dak@xxxxxxx> writes:
>
>> @@ -139,6 +154,18 @@ XSLTOPTS = --xinclude --stringparam html.stylesheet docbook-xsl.css
>> user-manual.html: user-manual.xml
>> xsltproc $(XSLTOPTS) -o $@ $(XSLT) $<
>>
>> +git.info: user-manual.xml
>> + $(RM) $@ $*.texi
>> + $(DOCBOOK2X_TEXI) user-manual.xml --to-stdout | \
>> + perl -ne 'if (/^\@setfilename/) {$$_="\@setfilename git.info\
>> +"} elsif (/^\@direntry/) {print "\@dircategory Development\
>> +\@direntry\
>> +* Git: (git). A fast distributed revision control system\
>> +\@end direntry\
>> +"} print unless (/^\@direntry/ .. /^\@end direntry/)' > $*.texi
>> + $(MAKEINFO) --no-split $*.texi
>> + $(RM) $*.texi
>> +
>
> This part worries me.
Aside from possible portability issue of multi-line script,
there is another slight problem I am not sure if it is worth
fixing. If you do not have docbook2x-texi installed, nobody
notices that resulting $*.texi was a garbage and an almost empty
git.info is generated.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
