On 8/25/2020 5:44 PM, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > >> From: Derrick Stolee <dstolee@xxxxxxxxxxxxx> >> >> Some commands run 'git maintenance run --auto --[no-]quiet' after doing >> their normal work, as a way to keep repositories clean as they are used. >> Currently, users who do not want this maintenance to occur would set the >> 'gc.auto' config option to 0 to avoid the 'gc' task from running. >> However, this does not stop the extra process invocation. > > OK, that is because the configuration is checked on the other side, > and the new check is implemented on this side before we decide to > spawn the maintenance task. > > It sounds like a change worth having without even waiting for the > "git maintenance" to materialize ;-). True. This one could be pulled out of Part III and placed any time after Part I (outside of test script context conflicts). The only reason to wait until after Part I is that the name "maintenance.auto" implies a connection to the maintenance builtin instead of gc. Before the maintenance builtin, it would be natural to see "gc.auto=0" and do this same behavior, but that will not be general enough in the future. If you prefer, I can pull this out into a series on its own to be tracked separately. Thanks, -Stolee
