On Tue, Aug 25, 2020 at 9:17 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > Runing them as "git remote-ext" and letting "git" dispatch to s/Runing/Running/ s/them/it/ > "remote-ext" would just be fine and is more idiomatic. > > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> > --- > diff --git a/transport-helper.c b/transport-helper.c > @@ -128,7 +128,8 @@ static struct child_process *get_helper(struct transport *transport) > - strvec_pushf(&helper->args, "git-remote-%s", data->name); > + strvec_push(&helper->args, "git"); > + strvec_pushf(&helper->args, "remote-%s", data->name); Rather than pushing "git" as the first argument, would it instead be more idiomatic to set `helper->git_cmd = 1` (or would that not work correctly for some reason)?
