On Tue, Aug 25, 2020 at 12:51:59PM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > >> As the intent for adding the "--stdin" option to any subcommand has > >> always been "we may need to feed many many things, that may bust the > >> command line length limit, hence we let you feed these things from > >> the standard input, but otherwise there should be no change in > >> behaviour or semantics", when the behaviour of command line and > >> "--stdin" differ, it is a bug in the latter. > > > > Agreed. It also helps in this case that the command-line behavior is > > sensible and the --stdin one is not. :) > > > > I think the solution is probably something like: > > You beat me to it while I was wondering what to do between the local > got_rev_arg variable and the revs->rev_input_given field. That makes me wonder why we need got_rev_arg at all if we have revs->rev_input_given. But I suspect an answer can be found by digging into git-blame. I probably won't do that immediately, so if you want to, you can do so without worrying that we're duplicating work. :) -Peff
