Jeff King <peff@xxxxxxxx> writes: > On Tue, Aug 25, 2020 at 12:35:24PM +0200, Patrick Steinhardt wrote: > >> The only change compared to v1 is that I've addressed the unportable >> `branch-{1..1000}` syntax in favor of `test_seq`. I had to setup refs as >> part of the setup and change the ordering for "update-ref --stdin" from >> create/update/delete to update/delete/create, but I don't think that's >> too bad. At least timings didn't seem to really change because of that. > > Another option instead of changing the order in the other tests is to do > another untimed setup step before the push test. I'm OK either way, > though. > >> +test_perf "nonatomic push" ' >> + git push ./target-repo.git $(test_seq 1000) && >> + git push --delete ./target-repo.git $(test_seq 1000) >> ' > > This works as far as Git is concerned, but "seq 1000" output with NULs > is 3893 bytes. I wonder if some platforms might run into command-line > limits there. That was my thought when I saw the above as well. In addition, I do not think it is a good idea to encourage digit-only refnames.