Kaartic Sivaraam <kaartic.sivaraam@xxxxxxxxx> writes:
>> @@ -1061,8 +1061,9 @@ static void generate_submodule_summary(struct summary_cb *info,
>> }
>>
>> if (S_ISGITLINK(p->mod_src)) {
>> - src_abbrev = verify_submodule_committish(p->sm_path,
>> - oid_to_hex(&p->oid_src));
>> + if (p->status != 'D')
>> + src_abbrev = verify_submodule_committish(p->sm_path,
>> + oid_to_hex(&p->oid_src));
>> if (!src_abbrev) {
>> missing_src = 1;
>> /*
Interesting. There is a mirroring if-else cascade that begins with
"if (S_ISGITLINK(p->mod_dst))" immediately after the if-else cascade
started here, and in there, the same verify_submodule_committish()
is called for oid_dst unconditionally. Should the asymmetry bother
readers of the code, or is the source side somehow special and needs
extra care?
