Jonathan Tan <jonathantanmy@xxxxxxxxxx> writes: > find_{ref,ofs}_delta_{,children} take an enum object_type parameter, but > the object type is already present in the name of the function. Remove > that parameter from these functions. Interesting. These "find children" are the only caller for each delta type and they always pass OFS/REF constant that corresponds to them, so find_*_delta() can lose the type. But compare_*_delta_bases() cannot, as the other one in the objects[] array may be of different type. Makes sense. Thanks.