Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes:
> On Wed, Aug 19, 2020 at 3:07 PM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> Junio C Hamano <gitster@xxxxxxxxx> writes:
>> > "Hariom Verma via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
>> >> +static int check_format_field(const char *arg, const char *field, const char **option)
>> >> +{
>> >> + else if (*opt == ':') {
>> >> + *option = ++opt;
>> >> + return 1;
>> >> + }
>>
>> And the helper does not have such a breakage. It looks good.
>
> One minor comment (not worth a re-roll): I personally found:
>
> *option = ++opt;
>
> more confusing than:
>
> *option = opt + 1;
>
> The `++opt` places a higher cognitive load on the reader. As a
> reviewer, I had to go back and carefully reread the function to see if
> the side-effect of `++opt` had some impact which I didn't notice on
> the first readthrough. The simpler `opt + 1` does not have a
> side-effect, thus is easier to reason about (and doesn't require me to
> re-study the function when I encounter it).
That makes the two of us ... thanks.
