On Thu, Aug 13, 2020 at 01:14:04AM +0530, Shourya Shukla wrote: > +static void print_submodule_summary(struct summary_cb *info, char* errmsg, > + int total_commits, const char *displaypath, > + const char *src_abbrev, const char *dst_abbrev, > + int missing_src, int missing_dst, > + struct module_cb *p) The "missing_src" and "missing_dst" parameters in this function are unused. I _think_ they can be safely removed, and are not a sign of a bug. We seem to fully handle them in the calling function. But this is the first time I looked at the code, and I didn't dig too deeply. -Peff
