Re: [PATCH v2 0/3] SHA-256: Update commit-graph and multi-pack-index formats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-08-17 at 14:04:45, Derrick Stolee via GitGitGadget wrote:
> As discussed [1], there is some concern around binary file formats requiring
> the context of the repository config in order to infer hash lengths. Two
> formats that were designed with the hash transition in mind (commit-graph
> and multi-pack-index) have bytes available to indicate the hash algorithm
> used. Let's actually update these formats to be more self-contained with the
> two hash algorithms being available.
> 
> [1] 
> https://lore.kernel.org/git/CAN0heSp024=Kyy7gdQ2VSetk_5iVhj_qdT8CMVPcry_AwWrhHQ@xxxxxxxxxxxxxx/
> 
> This merges cleanly with tb/bloom-improvements, but both that branch and
> this patch series have merge conflicts with the corrected commit date patch
> series [2].
> 
> [2] 
> https://lore.kernel.org/git/pull.676.v2.git.1596941624.gitgitgadget@xxxxxxxxx/

This series looked sane to me.  Thanks for the patches, and feel free to
have my

Reviewed-by: brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx>
-- 
brian m. carlson: Houston, Texas, US

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux