Re: [PATCH v17 06/10] receive-pack: feed report options to post-receive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jiang Xin <worldhello.net@xxxxxxxxx> writes:

> diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
> index 58972aa7cf..a687218167 100644
> --- a/builtin/receive-pack.c
> +++ b/builtin/receive-pack.c
> @@ -777,17 +777,38 @@ static int feed_receive_hook(void *state_, const char **bufp, size_t *sizep)
>  {
>  	struct receive_hook_feed_state *state = state_;
>  	struct command *cmd = state->cmd;
> +	static struct ref_push_report_options *options = NULL;

Exactly the same comment as "don't turn helper functions that can be
reused into unreusable ones by adding internal states" as one of the
previous patches applies here.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux