Re: [PATCH 3/5] make git-bugreport a builtin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> writes:

> Jeff King <peff@xxxxxxxx> writes:
>
>>     macros). That could change eventually of course, but it's not like
>>     switching back to a stand-alone at that point is a big deal.
>
> If it is not a big deal, then I am fine, but at the same time it
> becomes unclear why we can say "we can use X and Y niceties only
> available for builtins".

Actually, there is another issue that is potentially a lot worse.

"git bugreport" not being built-in would mean that the compiled-in
git-version MUST not be relied upon (it merely is a version of the
source "git bugreport" came from, it does not necessarily match the
main "git" binary when we are dealing with a confused user with
GIT_EXEC_PATH problem), but has to be asked to "git" binary on the
$PATH externally.  That needs to be done for any non-builtin
binaries (e.g. when user is having issue with git-remote--curl")
anyway, keeping "git bugreport" out of builtin would force us the
necessary discipline from early on.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux