Re: [PATCH v7 0/5] cleanup ra/rebase-i-more-options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:

> I offered three small suggestions how I think it could be improved, still,
> but I would be pretty happy with seeing the patches moving to `next`
> as-are.

I tend to agree with those points I saw you mentioned.

The unconditional exporting of the committer-date without undoing
looked like a bad pattern waiting to be copied and pasted.  I
have not yet fully followed the codepath but I tend to agree with
your suspicion that commit_tree_extended() might be a better place
to do this.

Thanks.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux