On 8/13/2020 11:08 AM, Jeff King wrote: > On Thu, Aug 13, 2020 at 11:04:28AM -0400, Taylor Blau wrote: > >> On Thu, Aug 13, 2020 at 10:57:19AM -0400, Jeff King wrote: >>> Over the years some more programs have become builtins, but nobody >>> updated this MSVC-specific section of the file (which specifically says >>> that it should not include builtins). Let's bring it up to date. >>> >>> Signed-off-by: Jeff King <peff@xxxxxxxx> >>> --- >>> Given that nobody has mentioned this, it makes me wonder if anybody is >>> even using this part of the Makefile at all these days. Or maybe having >>> extra lines here isn't a problem (though it's also missing some entries, >>> like one for git-bugreport). >> >> If having extra entries didn't cause a problem, I would suspect that it >> was just that. But that missing entries *also* doesn't cause a problem, >> I'd suspect that this section of the Makefile just isn't being used. >> >> Of course, I'm not using it since I'm not on Windows, but maybe dscho or >> Stolee would know if there are legitimate uses. Of course, if there >> aren't, I'm favor of getting rid of this section entirely. > > I cc'd Jeff Hostetler, who added it. :) > > I'm also pretty not-knowledgeable about Windows, but I think that > anybody using MSVC would do so through Visual Studio these days. And > that's being covered with recent cmake stuff. Or maybe I'm just > clueless. We'll see. We create PDBs for our microsoft/git installers, such as in this recent build: [1] [1] https://dev.azure.com/gvfs/ci/_build/results?buildId=18994&view=artifacts&type=publishedArtifacts Unzipping, I see PDBs for the git-* files listed in this command, minus the ones that don't exist. So if this line is what creates the PDBs, then it is not erroring out when trying to create the PDBs for commands that don't exist. Thanks, -Stolee
