On Wed, Aug 12, 2020 at 06:52:49PM +0200, René Scharfe wrote: > Like f0bca72dc77 (send-pack: use buffered I/O to talk to pack-objects, > 2016-06-08), significantly reduce the number of system calls and > simplify the code for sending object IDs to rev-list by using stdio's > buffering. > > Take care to handle errors immediately to get the correct error code, > and to flush the buffer explicitly before closing the stream in order to > catch any write errors for these last bytes. FWIW, the error handling in this patch and the other stdio conversions you sent all look good to me. Thanks (and to Chris and Johannes for great review on v1). -Peff
