Re: [PATCH] post-receive-email hook: handle order of arguments consistently

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 2007, August 07, Gerrit Pape wrote:
> The post-receive-email hook usually gets its arguments through stdin,
> but also supports them to be specified at the command line.  The order
> of the arguments should consistently follow the documentation no matter
> how they are passed to the script.


As I said the last time this was posted, this was done on purpose so that 
the command line arguments match the order of the arguments to the update 
hook.

Keeping them in that order allows the script to be used as an update hook in 
older versions of git.

Whether that is sensible or not is for Junio and the gang to decide; but 
there was good reason for doing it that way.  Also, I'm not sure what 
documentation you're talking about - use in command line mode is a bonus 
feature anyway, it's not necessary in normal hook mode anyway.  If you're 
going to be strict about matching documentation then the command line mode 
should be removed.



Andy

-- 
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@xxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux