Hi Aaron, By the way, welcome to the list! On Wed, 5 Aug 2020 at 00:02, Aaron Lipman <alipman88@xxxxxxxxx> wrote: > > Martin, thanks for your suggestions - I've moved the commit updating > "git bisect run" tests to 1/5, updated the commit message, and > included the changes you provided. (I held off on additional > indentation corrections, as it kinda felt like unnecessary code > churn/outside the scope of abstracting platform-specific details.) Ok, great, I think it's fine to stop there. Those spots really are in a much better shape now, thanks. > > (Signed-off-by: Martin Ågren <martin.agren@xxxxxxxxx>, FWIW.) > > I'm still getting used to the conventions - should I add your name as > a signed-off-by tag, a thanks-to tag, or both? What I meant was "oh, and here's my Signed-off-by for the record" so that we wouldn't need a round-trip of "cool, can I have your S-o-b on that?". Of course, I expressed that in such a lousy, compact way that we needed a round-trip *anyway*. :-/ And I'm not even sure we need a "Signed-off-by". I just posted the patch form of "If you look for chmod, you'll find a few more spots where you can do the exact same transformation, and you might want to look up test_expect_code." I see you added "Thanks-to" and I would have been fine with no mention at all. I think that patch looks good now, thanks. No need to think about the trailers for that patch now, I think you can safely focus on the later patches from now on. ;-) Martin
