On Wed, Aug 5, 2020 at 12:04 AM Aaron Lipman <alipman88@xxxxxxxxx> wrote: > > OK, here's take 4! Responding to Junio's feedback, first: [...] > Martin, thanks for your suggestions [...] It's better to have the people you are replying to as recipients of your emails (in the "To:" field). I have added them into "Cc:". > > (Signed-off-by: Martin Ågren <martin.agren@xxxxxxxxx>, FWIW.) > > I'm still getting used to the conventions - should I add your name as > a signed-off-by tag, a thanks-to tag, or both? We often use the following trailers: - "Helped-by:" when someone helped you - "Suggested-by:" when someone suggested the main idea in the patch - "Reported-by:" when someone reported an issue fixed by the patch - "Acked-by:" when someone explicitly acked the patch - "Reviewed-by:" when someone explicitly gave their "Reviewed-by:" If your patch is based on a patch from someone else, you can also keep the "Signed-off-by:" and other trailers that the person already put in the commit message. If you haven't made a lot of changes to a patch initially from someone else you can also keep them as the author. Thanks, Christian.
