On Tue, Aug 04, 2020 at 09:03:36AM -0400, Derrick Stolee wrote: > On 8/3/2020 2:57 PM, Taylor Blau wrote: > > Introduce a command-line flag and configuration variable to fill in the > > 'max_new_filters' variable introduced by the previous patch. > > > > The command-line option '--max-new-filters' takes precedence over > > 'graph.maxNewFilters', which is the default value. > > commitGraph.maxNewFilters? Nice catch. There are some other places that I made this typo, but I fixed those up locally, too. > > '--no-max-new-filters' can also be provided, which sets the value back > > to '-1', indicating that an unlimited number of new Bloom filters may be > > generated. (OPT_INTEGER only allows setting the '--no-' variant back to > > '0', hence a custom callback was used instead). > > Other than the commit message typo above, this is a good patch. Thanks, and thanks for the good suggestion to write it in the first place ;). > Thanks, > -Stolee Thanks, Taylor
