> Le 3 août 2020 à 20:26, Junio C Hamano <gitster@xxxxxxxxx> a écrit : > > "Philippe Blain via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > >> Changes since v1: >> >> * Incorporated Junio's suggestion to reduce duplication. >> >> v1: This series adds a list of the guides to git(1). >> >> The first commit adds the misssing guides 'gitcredentials' and >> 'gitremote-helpers' to command-list.txt. The only missing guide after this >> change is 'gitweb.conf', but I think this one is obscure anough, and already >> linked to in 'gitweb.txt', that it does not matter much. >> >> The second commit drops the usage of 'common' and 'useful' for guides. This >> was suggested as one of two ways forward by Duy in [1] but was not commented >> on. I'm CC'ing the people that were CC'ed on that message. >> >> The third commit tweaks 'Documentation/cmd-list.perl' so that it also >> generates a list of the guides, which gets included in 'git.txt'. I chose to >> put this list just after the end of the list of commands. >> >> [1] >> https://lore.kernel.org/git/CACsJy8ADj-bTMYDHxRNLOMppOEdPbVwL49u3XCfNBCmoLLZo+A@xxxxxxxxxxxxxx/ >> >> Philippe Blain (3): >> command-list.txt: add missing 'gitcredentials' and 'gitremote-helpers' >> help: drop usage of 'common' and 'useful' for guides >> git.txt: add list of guides > > I think the "dedup the list of cmds-$category.txt" is logically a > separate step from "we forgot to add guide category so add it", so > either (1) "add guide twice, and then refactor" or (2) "refactor > before adding guide, and then add guide only in one place" would be > more appropriate than (3) "add guide while refactoring". IMHO, (2) > would make the most sense. > I agree that (2) makes the most sense, I've split it for v3. (Your "SQUASH???" message on pb/guide-docs may have mislead me :) Philippe.
