On Mon, Aug 03, 2020 at 02:00:04PM -0400, Taylor Blau wrote: > Here's what I anticipate to be the final reroll of my series to teach > the new 'uploadpackfilter' configuration section, which allows for more > fine-grained control over which object filters upload-pack is willing to > serve. Thanks, this version looks good to me. > Two changes from last time: > > - I adopted Peff's suggestion in beginning in [1], but appropriately > split it over the existing patch structure. The adaptation looks good. The send_err_and_die() helper could possibly be used for some of the packet_writer_error() callers, too. Somebody could convert them on top if they want, but I'm not sure it's even worth it. IMHO the correct long-term direction is to convert those die() calls into silent exits and let the ERR packet speak for itself. But we shouldn't do that until the client side is more robust against pipe-death races. > - I dropped the old patch 3/4, since it really should have never been > there in the first place, and just made the refactoring more noisy > than necessary. Yeah, I think folding it in to the first patch as you did makes the series simpler to follow. -Peff
