On 7/30/2020 7:36 PM, Chris Torek wrote: > On Thu, Jul 30, 2020 at 3:26 PM Derrick Stolee via GitGitGadget > <gitgitgadget@xxxxxxxxx> wrote: >> diff --git a/builtin/gc.c b/builtin/gc.c >> index 99ab1f5e9d..d94eb3e6ad 100644 >> --- a/builtin/gc.c >> +++ b/builtin/gc.c >> @@ -988,6 +988,46 @@ static int multi_pack_index_expire(void) >> return 0; >> } >> >> +#define TWO_GIGABYTES (0x7FFF) > > You meant (0x7FFFFFFF) here, right? Ugh. Of course. Thanks for being diligent here. I hadn't pulled this branch into microsoft/git for testing with Scalar yet, where I would have noticed this. I'm tempted to create an EXPENSIVE test that actually checks this condition. Let's see what I can do. Thanks, -Stolee
