Note: re-send to mailing list due to me forgot to turn on Plain Text format.
(sorry for the noise)
Hi Peff, Taylor, Junio and Christian,
Thanks a lot for the valuable feedbacks.
This is exactly what I was hoping for by sending out the patch early!
> On Jul 31, 2020, at 21:14, Jeff King <peff@xxxxxxxx> wrote:
>
> On Fri, Jul 31, 2020 at 02:09:56PM -0400, Taylor Blau wrote:
>
>>> Is a single boolean flag sufficient? If you have incrementals, you might
>>> have some slices with this chunk and some without. What should the
>>> boolean be in that case?
>>
>> I think you'd really want to know which layers do and don't have
>> filters. It might be even more interesting to have a tool like what 'git
>> show-index' is to '*.idx' files, maybe something like 'git show-graph'
>> or 'git show-commit-graph'. Its output would be one line per commit that
>> shows:
>>
>> - what layer in the chain it's located at
>> - its graph_pos
>> - its generation number
>> - whether or not it has a Bloom filter
>> - ???
>>
>> That would be a useful tool for debugging anyway, even outside of the
>> test suite. It would be even better if we could replace the test-tool
>> with it.
>
> Yeah, that was exactly what I had in mind, except that I'd make it a
> sub-command of "git commit-graph" ("show" or perhaps "dump").
I loved Junio's initial suggestion and the follow up here.
I was thinking of something like 'git commit-graph verify --verbose' but
now I agree that a distinct command such as 'show' might be more
distinct and better communicate the purpose.
I will stick with my poor-man bash/golang script for now to invalidate
the commit-graph (chain or no-chain) as it does the job just fine.
Let me see if I have the capacity to implement 'show' sub-command
after. ^_^!
>
> -Peff
Cheers,
Son Luong.
