On Fri, Jul 31, 2020 at 10:14:39AM -0700, Junio C Hamano wrote: > "Son Luong Ngoc via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > > > From: Son Luong Ngoc <sluongng@xxxxxxxxx> > > > > Add '--has-changed-paths' option to 'git commit-graph verify' subcommand > > to validate whether the commit-graph was written with '--changed-paths' > > option. > > The implementation seems to be only about "does this section exist?" > and not "does this section have healthy/uncorrupted data?", which > feels a bit strange for "verify". Instead of setting ourselves up > to having to add "--has-this-section" and "--has-that-section" every > time a new kind of data is added to the system, how about giving the > verify command an option to list all the sections found in the file, > or a separate "git commit-graph list-sections" subcommand? Completely agreed. When I suggested that Son work on this, I more had in mind something like 'git commit-graph verify --changed-paths' to mean "verify the integrity of the commit-graph(s), including regenerating changed-path Bloom filters and making sure they match". If you are just curious whether or not the section exists, I'd rather write a script to look for the 'BIDX' or 'BDAT' chunk IDs. That said, if they're spread across incremental, maybe it makes more sense to extend the commit-graph test tool. I dunno. Thanks, Taylor
