On 7/29/2020 2:16 PM, Junio C Hamano wrote: > Derrick Stolee <stolee@xxxxxxxxx> writes: > >> I'll leave it to more experienced contributors to comment on how a >> comment-only patch fits with this section Documentation/CodingGuidelines: >> >> - Fixing style violations while working on a real change as a >> preparatory clean-up step is good, but otherwise avoid useless code >> churn for the sake of conforming to the style. >> >> In my opinion, this change is not harmful, but also isn't super >> necessary. I could go either way. > > Typofixes in comments has no chance of breaking things than a > carelessly done code churn made in the name of cleaning up, so > cost-benefit comparison is much more favourable. I'm sure that I > won't be exhausted after reviewing comment-only patch as much as > after reviewing code-churn only patch. Thanks. I appreciate the context that provides more clarity. Steve's patch with the de-duplicated sign-off has my full support. -Stolee
