On Sun, Jul 26, 2020 at 7:28 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > This change has the unfortunate side-effect that "git http-fetch -h" > will no longer work if setup_git_directory() fails, which could easily > be the case if the user is trying to get help for the command from > some arbitrary location in the filesystem. > > It might be better to setup_git_directory() on-demand when it's needed > by --packfile= rather than doing it unconditionally before the > argument-parsing loop. Better yet, use setup_git_directory_gently() before entering the argument-parsing loop.