Re: [PATCH v4 29/39] http-fetch: set up git directory before parsing pack hashes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jul 26, 2020 at 7:28 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote:
> This change has the unfortunate side-effect that "git http-fetch -h"
> will no longer work if setup_git_directory() fails, which could easily
> be the case if the user is trying to get help for the command from
> some arbitrary location in the filesystem.
>
> It might be better to setup_git_directory() on-demand when it's needed
> by --packfile= rather than doing it unconditionally before the
> argument-parsing loop.

Better yet, use setup_git_directory_gently() before entering the
argument-parsing loop.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux