Re: [PATCH v4 20/39] t8011: make hash size independent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jul 26, 2020 at 3:55 PM brian m. carlson
<sandals@xxxxxxxxxxxxxxxxxxxx> wrote:
> Allow lines which start with either a 40- or 64-character hex object ID,
> to allow for both SHA-1 and SHA-256.
>
> Signed-off-by: brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx>
> ---
> diff --git a/t/t8011-blame-split-file.sh b/t/t8011-blame-split-file.sh
> @@ -54,7 +54,7 @@ test_expect_success 'setup simulated porcelain' '
>         while (<>) {
> -               if (/^[0-9a-f]{40} /) {
> +               if (/^[0-9a-f]{40,64} /) {

Although this helps the current cases of SHA-1 and SHA-256, it doesn't
necessarily help people experimenting with other hash algorithms. I
wonder if it makes sense to loosen it a bit to simply look for
something that is likely to be an OID. Perhaps like this:

    if (/^[0-9a-f]{40,} /) {



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux